Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces in commandLineArgumentProvider values #1421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

audkar
Copy link

@audkar audkar commented Jun 21, 2023

A sample problem: android/nowinandroid#604

I think it's perfectly valid to have a space in a file path. But the current regex pattern explicitly does not allow spaces in command line arguments.

I looked in the git history for this formatting, but couldn't find a reason for such a restrictive pattern.

@audkar
Copy link
Author

audkar commented Jul 4, 2023

@ting-yuan What do you think? Would this be an appropriate fix for this problem?

@solrudev
Copy link

solrudev commented Feb 3, 2024

Will this be merged? I have a problem using AndroidX Room Gradle plugin due to having a whitespace in my user folder's name.

@naj147
Copy link

naj147 commented Mar 21, 2024

Hey, thank you for your effort on this, Is this fix going to be merged anytime soon? it has been approved almost a year ago.

@Zenturas
Copy link

is there some thoughts if this fix is going to be merged anytime soon?

@Deaths-Door
Copy link

Any updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants