Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC 3339 support for both Marshal and Unmarshal. #204

Merged
merged 7 commits into from
Apr 5, 2021
Merged

RFC 3339 support for both Marshal and Unmarshal. #204

merged 7 commits into from
Apr 5, 2021

Conversation

aren55555
Copy link
Contributor

@aren55555 aren55555 commented Apr 5, 2021 •
edited
Loading

Builds upon #201.

@aren55555
Copy link
Contributor Author

@quetzyg please take a quick peek and let me know what you think! This builds upon what @omarismail submitted in #201 (which I reverted yesterday in #202, due to missing the Serialization/Marshaling part, which I've now added)

This was referenced Apr 5, 2021
Merged
Open
quetzyg
quetzyg approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@quetzyg quetzyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left a few comments/suggestions.

request_test.go Show resolved Hide resolved
request_test.go Outdated Show resolved Hide resolved
request.go Outdated Show resolved Hide resolved
response_test.go Show resolved Hide resolved
@aren55555 @quetzyg
Update request_test.go
9559676 
Co-authored-by: Quetzy Garcia <[email protected]>
@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@aren55555 @quetzyg
Update request.go
05878cd 
Co-authored-by: Quetzy Garcia <[email protected]>
@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@aren55555
Copy link
Contributor Author

@googlebot I fixed it, @quetzyg was the author of the code and has accepted the CLA. The commits were with the email quetzy.garcia@i*******e.com which is @quetzyg.

@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@quetzyg
Copy link
Contributor

quetzyg commented Apr 5, 2021

Want me to sign CLA again @aren55555 ?

@aren55555
Copy link
Contributor Author

@quetzyg if possible yes please, would make my life a tad bit easier! You need to sign it with quetzy.garcia@i*******e.com

@google-cla
Copy link

google-cla bot commented Apr 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@quetzyg
Copy link
Contributor

quetzyg commented Apr 5, 2021

@aren55555 I've added my other email, so it should be sorted now.

@aren55555
Copy link
Contributor Author

@googlebot rescan plz

@aren55555 aren55555 merged commit f3b4acf into google:master Apr 5, 2021
@omarismail omarismail mentioned this pull request Apr 13, 2021
Closed
omarismail pushed a commit to hashicorp/jsonapi that referenced this pull request Apr 13, 2021
@aren55555 @quetzyg @omarismail
RFC 3339 support for both Marshal and Unmarshal. (google#204)
0223236 
* RFC 3339 support for both Marshal and Unmarshal.

* Post merge cleanup

* Update request_test.go

Co-authored-by: Quetzy Garcia <[email protected]>

* Spelling

* Update request.go

Co-authored-by: Quetzy Garcia <[email protected]>

* Simplify the ISO 8601 logic. No need for the const rfc3339TimeFormat use time.RFC3339 directly.

Co-authored-by: Quetzy Garcia <[email protected]>
@omarismail omarismail mentioned this pull request Apr 13, 2021
Merged
omarismail added a commit to hashicorp/jsonapi that referenced this pull request Apr 13, 2021
@omarismail
Match upstream (google/jsonapi) (#7)
353a8ff 
* Revert "Add RFC3339 timestamp (google#201)" (google#203)

This reverts commit c0ee6d2.

* RFC 3339 support for both Marshal and Unmarshal. (google#204)

* RFC 3339 support for both Marshal and Unmarshal.

* Post merge cleanup

* Update request_test.go

Co-authored-by: Quetzy Garcia <[email protected]>

* Update request.go

Co-authored-by: Quetzy Garcia <[email protected]>

* Simplify the ISO 8601 logic. No need for the const rfc3339TimeFormat use time.RFC3339 directly.

Co-authored-by: Quetzy Garcia <[email protected]>

* go mod init (google#205)

* parent 89dd8d2
author Omar Ismail <[email protected]> 1618325394 -0400
committer Omar Ismail <[email protected]> 1618326429 -0400
ctrombley pushed a commit to hashicorp/jsonapi that referenced this pull request Jan 12, 2024
@aren55555 @quetzyg @ctrombley
RFC 3339 support for both Marshal and Unmarshal. (google#204)
9db1fe8 
* RFC 3339 support for both Marshal and Unmarshal.

* Post merge cleanup

* Update request_test.go

Co-authored-by: Quetzy Garcia <[email protected]>

* Spelling

* Update request.go

Co-authored-by: Quetzy Garcia <[email protected]>

* Simplify the ISO 8601 logic. No need for the const rfc3339TimeFormat use time.RFC3339 directly.

Co-authored-by: Quetzy Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quetzyg quetzyg quetzyg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aren55555 @quetzyg