Fix pointers to alias types #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes pointers to type aliases which are currently not supported. The new test cases will fail with: jsonapi: Can't unmarshal foo (string) to struct field `String`, which is a pointer to `StringType (string)` One other method to fix this when you are able to modify your types is: type StringType = string This is the new (since Go 1.9) way to declare type aliasses which treats the types differently when using reflect. See: https://github.com/golang/example/tree/master/gotypes#named-types
erikdubbelboer
force-pushed
the
pointer-to-alias
branch
from
a7ce165
to
ec5ed79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes pointers to type aliases which are currently not
supported.
The new test cases will fail with:
One other method to fix this when you are able to modify your types is:
This is the new (since Go 1.9) way to declare type aliasses which treats
the types differently when using reflect.
See: https://github.com/golang/example/tree/master/gotypes#named-types