Migrate gnostic to use gnostic-models #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid a panic at runtime in a downstream project that pulls in gnostic and gnostic-models, create a new `<proto>.pbalias.go` file which uses type aliases and variables to point to the equivalent protobuf types in gnostic-models. This will prevent any API breakage for code using the previous types from gnostic, and allow for this logic to be maintained in one place going forward.
pkwarren
commented
Jul 13, 2023
| protoc -I . -I ./third_party --go_out=. --go_opt=paths=source_relative surface/*.proto | ||
| protoc -I . -I ./third_party --go_out=. --go_opt=paths=source_relative metrics/*.proto |
There was a problem hiding this comment.
Removed the directories which have proto definitions in gnostic-models, and noticed metrics was compiling twice.
|
@pkwarren is there an update needed now that google/gnostic-models#5 is merged? |
Yes - thanks for merging the dependency. I was out today but will aim to get this ready tomorrow. |
|
@timburks - This should be ready for re-review now. Let me know if you have any questions. |
|
Thanks @pkwarren LGTM - I'm not sure of all the downstream implications but I'm game to try this (and clients should be using tagged versions). Merging. |
timburks
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid a panic at runtime in a downstream project that pulls in gnostic and gnostic-models, create a new
<proto>.pbalias.gofile which uses type aliases and variables to point to the equivalent protobuf types in gnostic-models. This will prevent any API breakage for code using the previous types from gnostic, and allow for this logic to be maintained in one place going forward.Fixes #397.