JetBrains Mono: Version 2.305 added #8200
Conversation
Taken from the upstream repo https://github.com/JetBrains/JetBrainsMono at commit JetBrains/JetBrainsMono@b0a3712.
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.13.0a1 Check results[18] JetBrainsMono-Italic[wght].ttf
|
| WARN messages | Languages |
|---|---|
| Some auxiliary glyphs were missing: ѣ, ѫ | bg_Cyrl (Bulgarian) |
| Some auxiliary glyphs were missing: ἀ, ἁ, ἂ, ἃ, ἄ, ἅ, ἆ, ἇ, ἐ, ἑ, ἒ, ἓ, ἔ, ἕ, ἠ, ἡ, ἢ, ἣ, ἤ, ἥ, ἦ, ἧ, ἰ, ἱ, ἲ, ἳ, ἴ, ἵ, ἶ, ἷ, ὂ, ὃ, ὄ, ὐ, ὑ, ὒ, ὓ, ὔ, ὕ, ὖ, ὗ, ὢ, ὣ, ὤ, ὥ, ὦ, ὧ, ᾶ, ῆ, ῖ, ῗ, ῦ, ῧ, ῶ | el_Grek (Greek) |
| Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️ WARNThe dot of soft dotted characters should disappear in other cases, for example: 𝕚̀ 𝕚́ 𝕚̂ 𝕚̃ 𝕚̄ 𝕚̆ 𝕚̇ 𝕚̈ 𝕚̉ 𝕚̊ 𝕚̋ 𝕚̌ 𝕚̏ 𝕚̒ 𝕚̥̀ 𝕚̥́ 𝕚̥̂ 𝕚̥̃ 𝕚̥̄ 𝕚̥̆
Your font fully covers the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Lithuanian (Latn, 2,357,094 speakers), Igbo (Latn, 27,823,640 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Dutch (Latn, 31,709,104 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Bete-Bendi (Latn, 100,000 speakers), Ejagham (Latn, 120,000 speakers), Cicipu (Latn, 44,000 speakers), Avokaya (Latn, 100,000 speakers), Nateni (Latn, 100,000 speakers), Kom (Latn, 360,685 speakers), Ngbaka (Latn, 1,020,000 speakers), Mango (Latn, 77,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Mundani (Latn, 34,000 speakers), Mfumte (Latn, 79,000 speakers), Sar (Latn, 500,000 speakers), Bafut (Latn, 158,146 speakers), Dan (Latn, 1,099,244 speakers), Yala (Latn, 200,000 speakers), Basaa (Latn, 332,940 speakers), Ekpeye (Latn, 226,000 speakers), Gulay (Latn, 250,478 speakers), Zapotec (Latn, 490,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Southern Kisi (Latn, 360,000 speakers), Koonzime (Latn, 40,000 speakers), Dii (Latn, 71,000 speakers), Aghem (Latn, 38,843 speakers), Ma’di (Latn, 584,000 speakers), Fur (Latn, 1,230,163 speakers), Vute (Latn, 21,000 speakers), Makaa (Latn, 221,000 speakers), Ebira (Latn, 2,200,000 speakers), South Central Banda (Latn, 244,000 speakers), Lugbara (Latn, 2,200,000 speakers), Nzakara (Latn, 50,000 speakers).
[code: soft-dotted]⚠️ WARN Are there any misaligned on-curve points?
⚠️ WARNThe following glyphs have on-curve points which have potentially incorrect y coordinates:
* Aogonek (U+0104): X=490.0,Y=1.0 (should be at baseline 0?)
* Eogonek (U+0118): X=430.0,Y=1.0 (should be at baseline 0?)
* Iogonek (U+012E): X=290.0,Y=1.0 (should be at baseline 0?)
* uni01EA (U+01EA): X=357.0,Y=1.0 (should be at baseline 0?)
* Uogonek (U+0172): X=357.0,Y=1.0 (should be at baseline 0?)
* eogonek (U+0119): X=356.0,Y=1.0 (should be at baseline 0?)
* iogonek (U+012F): X=305.0,Y=1.0 (should be at baseline 0?)
* uni01EB (U+01EB): X=355.0,Y=1.0 (should be at baseline 0?)
* uogonek (U+0173): X=355.0,Y=1.0 (should be at baseline 0?)
* uogonek.cv12: X=449.0,Y=1.0 (should be at baseline 0?)
* 37 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-misalignments]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
| ofl/jetbrainsmono/JetBrainsMono-Italic[wght].ttf | |
|---|---|
| Dehinted Size | 301.6kb |
| Hinted Size | 301.6kb |
| Increase | 24 bytes |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/JetBrains/JetBrainsMono
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][18] JetBrainsMono[wght].ttf
⚠️ WARN Checking correctness of monospaced metadata.
⚠️ WARNThe OpenType spec recommends at https://learn.microsoft.com/en-us/typography/opentype/spec/recom#hhea-table that hhea.numberOfHMetrics be set to 3 but this font has 1717 instead.
Please read hhea.numberOfHMetrics not correct for monospace fonttools/fonttools#3014 to decide whether this makes sense for your font.
[code: bad-numberOfHMetrics]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
⚠️ WARNdcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️ WARN Check font contains no unreachable glyphs
⚠️ WARNThe following glyphs could not be reached by codepoint or substitution rules:
- NULL
- bar_bar_bar.liga
- uni0306.cy
- uni0311.case
- uni0324.case
- uni0326.alt
- uni032E.case
- uni0331.case
- uni2070.zero
- uni2080.zero
- zero.dnom.zero
- zero.numr.zero
[code: unreachable-glyphs]
⚠️ WARN Glyph names are all valid?
⚠️ WARNThe following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
ampersand_ampersand_ampersand.liga, ampersand_ampersand_ampersand.liga.cv15, asciitilde_asciitilde_greater.liga, braceleft_braceleft_hyphen_hyphen.liga, braceleft_exclam_hyphen_hyphen.liga, hyphen_hyphen_braceright_braceright.liga, less_numbersign_hyphen_hyphen.liga, numbersign_numbersign_numbersign.liga, numbersign_numbersign_numbersign_numbersign.liga, numbersign_underscore_parenleft.liga and semicolon_semicolon_semicolon.liga
[code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
⚠️ WARNFamily metadata at ofl/jetbrainsmono does not have an article.
[code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
- U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
- U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, tifinagh, coptic, cherokee
- U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
- U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, tifinagh, todhri, hebrew, math, malayalam, coptic, old-permic, duployan, syriac, canadian-aboriginal
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
- U+030F COMBINING DOUBLE GRAVE ACCENT: not included in any glyphset definition 652 more.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, greek, latin, latin-ext, menu, vietnamese
⚠️ WARN Shapes languages in all GF glyphsets.
⚠️ WARNGF_Phonetics_SinoExt glyphset:
| WARN messages | Languages |
|---|---|
| Some auxiliary glyphs were missing: ѣ, ѫ | bg_Cyrl (Bulgarian) |
| Some auxiliary glyphs were missing: ἀ, ἁ, ἂ, ἃ, ἄ, ἅ, ἆ, ἇ, ἐ, ἑ, ἒ, ἓ, ἔ, ἕ, ἠ, ἡ, ἢ, ἣ, ἤ, ἥ, ἦ, ἧ, ἰ, ἱ, ἲ, ἳ, ἴ, ἵ, ἶ, ἷ, ὂ, ὃ, ὄ, ὐ, ὑ, ὒ, ὓ, ὔ, ὕ, ὖ, ὗ, ὢ, ὣ, ὤ, ὥ, ὦ, ὧ, ᾶ, ῆ, ῖ, ῗ, ῦ, ῧ, ῶ | el_Grek (Greek) |
| Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️ WARNThe dot of soft dotted characters should disappear in other cases, for example: 𝕚̀ 𝕚́ 𝕚̂ 𝕚̃ 𝕚̄ 𝕚̆ 𝕚̇ 𝕚̈ 𝕚̉ 𝕚̊ 𝕚̋ 𝕚̌ 𝕚̏ 𝕚̒ 𝕚̥̀ 𝕚̥́ 𝕚̥̂ 𝕚̥̃ 𝕚̥̄ 𝕚̥̆
Your font fully covers the following languages that require the soft-dotted feature: Navajo (Latn, 166,319 speakers), Lithuanian (Latn, 2,357,094 speakers), Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Dutch (Latn, 31,709,104 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Bete-Bendi (Latn, 100,000 speakers), Ejagham (Latn, 120,000 speakers), Cicipu (Latn, 44,000 speakers), Avokaya (Latn, 100,000 speakers), Igbo (Latn, 27,823,640 speakers), Nateni (Latn, 100,000 speakers), Kom (Latn, 360,685 speakers), Ngbaka (Latn, 1,020,000 speakers), Mango (Latn, 77,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Mundani (Latn, 34,000 speakers), Mfumte (Latn, 79,000 speakers), Sar (Latn, 500,000 speakers), Bafut (Latn, 158,146 speakers), Dan (Latn, 1,099,244 speakers), Yala (Latn, 200,000 speakers), Basaa (Latn, 332,940 speakers), Ekpeye (Latn, 226,000 speakers), Gulay (Latn, 250,478 speakers), Zapotec (Latn, 490,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Southern Kisi (Latn, 360,000 speakers), Koonzime (Latn, 40,000 speakers), Dii (Latn, 71,000 speakers), Aghem (Latn, 38,843 speakers), Ma’di (Latn, 584,000 speakers), Fur (Latn, 1,230,163 speakers), Vute (Latn, 21,000 speakers), Makaa (Latn, 221,000 speakers), Ebira (Latn, 2,200,000 speakers), South Central Banda (Latn, 244,000 speakers), Lugbara (Latn, 2,200,000 speakers), Nzakara (Latn, 50,000 speakers).
[code: soft-dotted]⚠️ WARN Are there any misaligned on-curve points?
⚠️ WARNThe following glyphs have on-curve points which have potentially incorrect y coordinates:
* Aogonek (U+0104): X=534.0,Y=1.0 (should be at baseline 0?)
* Eogonek (U+0118): X=474.0,Y=1.0 (should be at baseline 0?)
* Iogonek (U+012E): X=334.0,Y=1.0 (should be at baseline 0?)
* uni01EA (U+01EA): X=401.0,Y=1.0 (should be at baseline 0?)
* Uogonek (U+0172): X=401.0,Y=1.0 (should be at baseline 0?)
* eogonek (U+0119): X=400.0,Y=1.0 (should be at baseline 0?)
* iogonek (U+012F): X=349.0,Y=1.0 (should be at baseline 0?)
* uni01EB (U+01EB): X=399.0,Y=1.0 (should be at baseline 0?)
* uogonek (U+0173): X=399.0,Y=1.0 (should be at baseline 0?)
* uogonek.cv12: X=493.0,Y=1.0 (should be at baseline 0?)
* 37 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-misalignments]⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
| ofl/jetbrainsmono/JetBrainsMono[wght].ttf | |
|---|---|
| Dehinted Size | 293.1kb |
| Hinted Size | 293.1kb |
| Increase | 24 bytes |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/JetBrains/JetBrainsMono
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
| 💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
|---|---|---|---|---|---|---|---|
| 0 | 0 | 0 | 20 | 81 | 17 | 370 | 0 |
| 0% | 0% | 0% | 4% | 17% | 3% | 76% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
|
@emmamarichal is this upgrade related to #7881?
Please let me know if these changes are intended. |
|
@vv-monsalve Yes sorry, I forgot to link the issue, just did it! For the greek, I must admit I don't really know, I thought it was a design choice improvement. Let me confirm with the designer! For tracking: JetBrains/JetBrainsMono#699 |
Taken from the upstream repo https://github.com/JetBrains/JetBrainsMono at commit JetBrains/JetBrainsMono@b0a3712.
PR Checklist:
minisite_urldefinition in the METADATA.pb file for commissioned projectsprimary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.