You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Family categorization tags collected from the type design team with the Categories Form
Minisite_url definition in the METADATA.pb file for commissioned projects
Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
Diffenator2 regression checks for revisions on all projects that are currently in production
Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
These won't break the CI job for now, but will become effective after some time if nobody raises any concern.
[2] Beiruti[wght].ttf
⚠️WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
⚠️WARN
Family metadata at ofl/beiruti does not have an article.
[code: lacks-article]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
All other checks
[27] Beiruti[wght].ttf
🔥 FAIL METADATA.pb font.full_name and font.post_script_name fields have equivalent values ?
🔥 FAIL
METADATA.pb font full_name = "Beiruti" does not match post_script_name = "Beiruti-Regular"
[code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL
GF_Latin_Core glyphset:
Language
FAIL messages
nl_Latn (Dutch)
Shaper didn't attach Acute to J
^
Shaper didn't attach Acute to j
[code: failed-language-shaping]
🔥 FAIL
GF_Latin_Vietnamese glyphset:
Language
FAIL messages
vi_Latn (Vietnamese)
Some mark glyphs were missing: ◌̛
[code: failed-language-shaping]
🔥 FAIL
GF_Arabic_Core glyphset:
Language
FAIL messages
ar_Arab (Arabic)
Shaper didn't attach uni0653 to None
^
Shaper didn't attach uni0654 to None
^
Shaper didn't attach uni0655 to None
^
Shaper didn't attach uni0653 to space
^
Shaper didn't attach uni0654 to space
^
Shaper didn't attach uni0655 to space
^
Shaper didn't attach uni0670 to space
^
Shaper didn't attach uni064B to space
^
Shaper didn't attach uni064C to space
^
Shaper didn't attach uni064D to space
^
Shaper didn't attach uni064E to space
^
Shaper didn't attach uni064F to space
^
Shaper didn't attach uni0650 to space
^
Shaper didn't attach uni0651 to space
^
Shaper didn't attach uni0652 to space
^
Shaper didn't attach uni0670 to uni0640
^
Shaper didn't attach uni0653 to uni0640
^
Shaper didn't attach uni0654 to uni0640
^
Shaper didn't attach uni0655 to uni0640
^
Shaper didn't attach uni064B to uni0640
^
Shaper didn't attach uni064C to uni0640
^
Shaper didn't attach uni064D to uni0640
^
Shaper didn't attach uni064E to uni0640
^
Shaper didn't attach uni064F to uni0640
^
Shaper didn't attach uni0650 to uni0640
^
Shaper didn't attach uni0651 to uni0640
^
Shaper didn't attach uni0652 to uni0640
[code: failed-language-shaping]
🔥 FAIL
GF_Arabic_Core glyphset:
Language
FAIL messages
fa_Arab (Persian)
Shaper didn't attach uni0654 to None
^
Shaper didn't attach uni0654 to space
[code: failed-language-shaping]
⚠️WARN Check mark characters are in GDEF mark glyph class.
⚠️WARN
The following mark characters could be in the GDEF mark glyph class:
Acute (U+0301), Breve (U+0306), Caron (U+030C), Cedilla (U+0327), Circumflex (U+0302), Comma.high (U+0313), Commaaccent (U+0326), Dieresis (U+0308), Dotaccent (U+0307), Dotbelow (U+0323) and 12 more.
Use -F or --full-lists to disable shortening of long lists.
[code: mark-chars]
⚠️WARN Check GDEF mark glyph class doesn't have characters that are not marks.
⚠️WARN
The following non-mark characters should not be in the GDEF mark glyph class:
U+FC5E, U+FC5F, U+FC60, U+FC61, U+FC62 and U+FC63
[code: non-mark-chars]
⚠️WARN Check accent of Lcaron, dcaron, lcaron, tcaron
⚠️WARN
dcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️WARN
Lcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️WARN
lcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️WARN
tcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️WARN Detect any interpolation issues in the font.
⚠️WARN
Interpolation issues were found in the font:
- Contour 1 point 7 in glyph 'ae' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'uni1E20' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'Gbreve' has a kink between location wght=200 and location wght=900
- Contour 0 point 39 in glyph 'sterling' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'Gcommaaccent' has a kink between location wght=200 and location wght=900
- Contour 1 point 7 in glyph 'aeacute' has a kink between location wght=200 and location wght=900
- Contour 0 start point differs in glyph 'O64F' between location wght=400 and location wght=200
- Contour 0 in glyph 'O64F': becomes underweight between wght=400 and wght=200.
- Contour 2 start point differs in glyph 'O64F' between location wght=400 and location wght=200
- Contour 2 in glyph 'O64F': becomes underweight between wght=400 and wght=200.
- 49 more.
Use -F or --full-lists to disable shortening of long lists.
[code: interpolation-issues]
⚠️WARN Check math signs have the same width.
⚠️WARN
The most common width is 480 among a set of 19 math glyphs.
The following math glyphs have a different width, though:
Width = 683:
notelement, suchthat, element
Width = 612:
proportional
Width = 929:
orthogonal
Width = 1164:
angle
Width = 928:
uni2237
[code: width-outliers]
⚠️WARN Does the font contain a soft hyphen?
⚠️WARN
This font has a 'Soft Hyphen' character.
[code: softhyphen]
⚠️WARN Glyph names are all valid?
⚠️WARN
The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
extendedarabicindicdigitfoururdu.lining and extendedarabicindicdigitsevenurdu.lining
[code: legacy-long-names]
⚠️WARN Check the direction of the outermost contour in each glyph
⚠️WARN
The following glyphs have a counter-clockwise outer contour:
* .notdef has a counter-clockwise outer contour
* A (U+0041) has a counter-clockwise outer contour
* AE (U+00C6) has a counter-clockwise outer contour
* AEacute (U+01FC) has a counter-clockwise outer contour
* AEacute (U+01FC) has a counter-clockwise outer contour
* Aacute (U+00C1) has a counter-clockwise outer contour
* Aacute (U+00C1) has a counter-clockwise outer contour
* Abreve (U+0102) has a counter-clockwise outer contour
* Abreve (U+0102) has a counter-clockwise outer contour
* Acircumflex (U+00C2) has a counter-clockwise outer contour
* 1841 more.
Use -F or --full-lists to disable shortening of long lists.
[code: ccw-outer-contour]
⚠️WARN Ensure dotted circle glyph is present and can attach marks.
⚠️WARN
No dotted circle glyph present
[code: missing-dotted-circle]
⚠️WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️WARN
The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ i̓ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌ ḭ̀ ḭ́ ḭ̄ ị̀ ị́ ị̂ ị̃ ị̄
The dot of soft dotted characters should disappear in other cases, for example: i̇ i̒ i̦̇ i̦̊ i̦̋ i̦̒ i̦̓ i̧̇ i̧̊ i̧̋ i̧̒ i̧̓ j̆ j̇ j̉ j̊ j̋ j̒ j̓ j̣̀
Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).
⚠️WARN Check for codepoints not covered by METADATA subsets.
⚠️WARN
The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
U+02C7 CARON: try adding one of: canadian-aboriginal, tifinagh, yi
U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, coptic, math
U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ INFO Show hinting filesize impact.
ℹ️ INFO
Hinting filesize impact:
ofl/beiruti/Beiruti[wght].ttf
Dehinted Size
664.1kb
Hinted Size
664.2kb
Increase
24 bytes
Change
0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.00']
[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
ℹ️ INFO
None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]
Summary
💥 ERROR
☠ FATAL
🔥 FAIL
⚠️ WARN
⏩ SKIP
ℹ️ INFO
✅ PASS
🔎 DEBUG
0
0
2
18
41
10
177
0
0%
0%
1%
7%
17%
4%
71%
0%
Note: The following loglevels were omitted in this report:
Please advise what do to about the full_name FAIL.
Also, I noticed that it won't have a Arabic subset in METADATA. I should probably fix that. The same goes for Zain btw.
These won't break the CI job for now, but will become effective after some time if nobody raises any concern.
[2] Beiruti[wght].ttf
⚠️WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
⚠️WARN
Family metadata at ofl/beiruti does not have an article.
[code: lacks-article]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
All other checks
[27] Beiruti[wght].ttf
🔥 FAIL METADATA.pb font.full_name and font.post_script_name fields have equivalent values ?
🔥 FAIL
METADATA.pb font full_name = "Beiruti" does not match post_script_name = "Beiruti-Regular"
[code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL
GF_Latin_Core glyphset:
Language
FAIL messages
nl_Latn (Dutch)
Shaper didn't attach Acute to J
^
Shaper didn't attach Acute to j
[code: failed-language-shaping]
🔥 FAIL
GF_Latin_Vietnamese glyphset:
Language
FAIL messages
vi_Latn (Vietnamese)
Some mark glyphs were missing: ◌̛
[code: failed-language-shaping]
🔥 FAIL
GF_Arabic_Core glyphset:
Language
FAIL messages
ar_Arab (Arabic)
Shaper didn't attach uni0653 to None
^
Shaper didn't attach uni0654 to None
^
Shaper didn't attach uni0655 to None
^
Shaper didn't attach uni0653 to space
^
Shaper didn't attach uni0654 to space
^
Shaper didn't attach uni0655 to space
^
Shaper didn't attach uni0670 to space
^
Shaper didn't attach uni064B to space
^
Shaper didn't attach uni064C to space
^
Shaper didn't attach uni064D to space
^
Shaper didn't attach uni064E to space
^
Shaper didn't attach uni064F to space
^
Shaper didn't attach uni0650 to space
^
Shaper didn't attach uni0651 to space
^
Shaper didn't attach uni0652 to space
^
Shaper didn't attach uni0670 to uni0640
^
Shaper didn't attach uni0653 to uni0640
^
Shaper didn't attach uni0654 to uni0640
^
Shaper didn't attach uni0655 to uni0640
^
Shaper didn't attach uni064B to uni0640
^
Shaper didn't attach uni064C to uni0640
^
Shaper didn't attach uni064D to uni0640
^
Shaper didn't attach uni064E to uni0640
^
Shaper didn't attach uni064F to uni0640
^
Shaper didn't attach uni0650 to uni0640
^
Shaper didn't attach uni0651 to uni0640
^
Shaper didn't attach uni0652 to uni0640
[code: failed-language-shaping]
🔥 FAIL
GF_Arabic_Core glyphset:
Language
FAIL messages
fa_Arab (Persian)
Shaper didn't attach uni0654 to None
^
Shaper didn't attach uni0654 to space
[code: failed-language-shaping]
⚠️WARN Check mark characters are in GDEF mark glyph class.
⚠️WARN
The following mark characters could be in the GDEF mark glyph class:
Acute (U+0301), Breve (U+0306), Caron (U+030C), Cedilla (U+0327), Circumflex (U+0302), Comma.high (U+0313), Commaaccent (U+0326), Dieresis (U+0308), Dotaccent (U+0307), Dotbelow (U+0323) and 12 more.
Use -F or --full-lists to disable shortening of long lists.
[code: mark-chars]
⚠️WARN Check GDEF mark glyph class doesn't have characters that are not marks.
⚠️WARN
The following non-mark characters should not be in the GDEF mark glyph class:
U+FC5E, U+FC5F, U+FC60, U+FC61, U+FC62 and U+FC63
[code: non-mark-chars]
⚠️WARN Check accent of Lcaron, dcaron, lcaron, tcaron
⚠️WARN
dcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️WARN
Lcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️WARN
lcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️WARN
tcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️WARN Detect any interpolation issues in the font.
⚠️WARN
Interpolation issues were found in the font:
- Contour 0 point 39 in glyph 'sterling.fitted' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'uni1E20' has a kink between location wght=200 and location wght=900
- Contour 0 point 42 in glyph 'uni2126' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'Gcircumflex' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'G' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'Gcaron' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'Gbreve' has a kink between location wght=200 and location wght=900
- Contour 1 point 7 in glyph 'aeacute' has a kink between location wght=200 and location wght=900
- Contour 0 point 23 in glyph 'Gcommaaccent' has a kink between location wght=200 and location wght=900
- Contour 2 start point differs in glyph 'O64C' between location wght=400 and location wght=200
- 49 more.
Use -F or --full-lists to disable shortening of long lists.
[code: interpolation-issues]
⚠️WARN Check math signs have the same width.
⚠️WARN
The most common width is 480 among a set of 19 math glyphs.
The following math glyphs have a different width, though:
Width = 683:
notelement, suchthat, element
Width = 612:
proportional
Width = 929:
orthogonal
Width = 1164:
angle
Width = 928:
uni2237
[code: width-outliers]
⚠️WARN Does the font contain a soft hyphen?
⚠️WARN
This font has a 'Soft Hyphen' character.
[code: softhyphen]
⚠️WARN Glyph names are all valid?
⚠️WARN
The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
extendedarabicindicdigitfoururdu.lining and extendedarabicindicdigitsevenurdu.lining
[code: legacy-long-names]
⚠️WARN Check the direction of the outermost contour in each glyph
⚠️WARN
The following glyphs have a counter-clockwise outer contour:
* .notdef has a counter-clockwise outer contour
* A (U+0041) has a counter-clockwise outer contour
* AE (U+00C6) has a counter-clockwise outer contour
* AEacute (U+01FC) has a counter-clockwise outer contour
* AEacute (U+01FC) has a counter-clockwise outer contour
* Aacute (U+00C1) has a counter-clockwise outer contour
* Aacute (U+00C1) has a counter-clockwise outer contour
* Abreve (U+0102) has a counter-clockwise outer contour
* Abreve (U+0102) has a counter-clockwise outer contour
* Acircumflex (U+00C2) has a counter-clockwise outer contour
* 1841 more.
Use -F or --full-lists to disable shortening of long lists.
[code: ccw-outer-contour]
⚠️WARN Ensure dotted circle glyph is present and can attach marks.
⚠️WARN
No dotted circle glyph present
[code: missing-dotted-circle]
⚠️WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️WARN
The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ i̓ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌ ḭ̀ ḭ́ ḭ̄ ị̀ ị́ ị̂ ị̃ ị̄
The dot of soft dotted characters should disappear in other cases, for example: i̇ i̒ i̦̇ i̦̊ i̦̋ i̦̒ i̦̓ i̧̇ i̧̊ i̧̋ i̧̒ i̧̓ j̆ j̇ j̉ j̊ j̋ j̒ j̓ j̣̀
Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers).
⚠️WARN Check for codepoints not covered by METADATA subsets.
⚠️WARN
The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
U+02C7 CARON: try adding one of: yi, tifinagh, canadian-aboriginal
U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ INFO Show hinting filesize impact.
ℹ️ INFO
Hinting filesize impact:
ofl/beiruti/Beiruti[wght].ttf
Dehinted Size
664.1kb
Hinted Size
664.2kb
Increase
24 bytes
Change
0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.00']
[code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
ℹ️ INFO
None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
('wght', 1)
[code: summary]
Summary
💥 ERROR
☠ FATAL
🔥 FAIL
⚠️ WARN
⏩ SKIP
ℹ️ INFO
✅ PASS
🔎 DEBUG
0
0
2
18
41
10
177
0
0%
0%
1%
7%
17%
4%
71%
0%
Note: The following loglevels were omitted in this report:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yanone
added
I New Font
II Accepted
Taken from the upstream repo https://github.com/googlefonts/beiruti at commit googlefonts/beiruti@f6d75f1.
Resolves #7625
PR Checklist: