ofl/robotoflex/article updated with youtube embed #7519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't have the desired effect until b/332954475 is solved. Added a comment on that ticket. |
|
Isn't this somehow repeated on #7518? (Could this change be handled there?) |
Not really. This one is about an upcoming feature where we allow YouTube embeds directly on the about page. The jpg optimization from #7518 will probably land before this feature, so still good to have both. |
|
Thanks, Tomas, for the clarification. We'll wait for your signal then for when b/332954475 is solved to merge this PR. |
|
b/332954475 has been fixed, feel free to squash and merge this one whenever! |
m4rc1e
pushed a commit
to m4rc1e/fonts
that referenced
this pull request
Apr 11, 2024
* ofl/robotoflex/article updated with youtube embed * ofl/robotoflex/article updated with youtube embed
m4rc1e
pushed a commit
to m4rc1e/fonts
that referenced
this pull request
Apr 11, 2024
* ofl/robotoflex/article updated with youtube embed * ofl/robotoflex/article updated with youtube embed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per internal discussion, perhaps we can embed youtube videos on specimen pages properly rather than the current workaround :)