Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing negative child width when shrinking on no wrap #639

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

siczmj
Copy link

@siczmj siczmj commented Apr 22, 2024

This minor change fixes an issue where a child view may have a negative width during shrinking in no wrap flex wrap mode.
If you look at the playground app, you will be able to reproduce it by setting the wrap mode to no wrap, and merely add more than 10 items. The horizontal FlexLine measurement going to be modified incorrectly due to a negative child view width. This may happen if a child view is already narrow and you force to shrink more.

Issue before fix Correct behavior after fix
no-wrap-shrinking-issue-negative-child-measure-width no-wrap-shrinking-fix-negative-child-measure-width

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant