Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strange space at the top when FlexWrap (#522) #530

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sheckspir
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sheckspir
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

} else {
anchorInfo.mCoordinate = mOrientationHelper.getStartAfterPadding() +
savedState.mAnchorOffset;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not a correct way to fix the issue.

Actually some of the tests in FlexboxLayoutMangerTests are failing after patching this PR.

Couldn't look into the issue carefully, but I guess what needs to be cared is not whether the main axis direction is horizontal, but whether the flex wrap is nowrap.

Copy link
Contributor

@thagikura thagikura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

But looks like existing tests are failing, also is it possible to add a test to FlexboxLayoutManager to verify the fix?

@sheckspir
Copy link
Author

@thagikura Yes, you was right. It was a bad way to resolve it. I looked on it some more, and I saw, that you change OrientationHelper for a situation, when flexWrap != NOWRAP. It makes sense. Because scrolling, in this case, goes otherways
But we have a small problem. FlexboxLayoutManager calculate offset position from leftPadding, but should use topPadding (or bottomPadding for reverse)
So I used SubOrientationHelper as you did in method assignFromView(View anchor)

@thagikura
Copy link
Contributor

Sorry for the delayed replay..

Thanks for the new commit! Yup, the fix looks like what I intended. But noticed that FlexboxLayoutManager.testDrawDirtyFlexLine_multi_viewTypes_direction_row fails consistently.

Haven't spotted what causes the failure, but is it possible to check on your end, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants