Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick transparent renderables #8190

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

show50726
Copy link

Based on #6633 by @grassydragon, I continue to finish the requirements by @pixelflinger:

This is what I would like to see:

  • have an option to include or not the transparents. I think there is value to not include the transparents in picking.
  • reuse the structure pass in the case transparents are not included (each extra pass costs about the same as a shadow pass, it's not insignificant). Thanks to the framegraph design this can be done pretty easily: keep the old code, keep the new code and just select which "picking" resource you want to use based on wether transparents should be included -- the framegraph will take care of removing the pass that's not needed.

Here's what I did:

  • Add a boolean in FView to select whether to pick transparent entities
  • Use structure pass when the boolean is false, otherwise use a separate Picking Render Pass

Closes #6614

@show50726 show50726 marked this pull request as ready for review October 10, 2024 17:09
@pixelflinger pixelflinger self-requested a review October 10, 2024 18:11
@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Oct 10, 2024
filament/src/details/Renderer.cpp Outdated Show resolved Hide resolved
filament/src/details/View.h Outdated Show resolved Hide resolved
filament/src/details/View.h Outdated Show resolved Hide resolved
@grassydragon
Copy link

Hi @show50726!
Thank you for continuing working on this feature!

filament/src/details/View.h Outdated Show resolved Hide resolved
filament/src/details/Renderer.cpp Outdated Show resolved Hide resolved
Fix the texture format

Decide texture format based on feature level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picking transparent renderables
4 participants