Skip to content

Commit

Permalink
Update Dagger/Hilt artifact tests to use kotlin 1.9
Browse files Browse the repository at this point in the history
RELNOTES=N/A
PiperOrigin-RevId: 558176324
  • Loading branch information
bcorso authored and Dagger Team committed Aug 18, 2023
1 parent b37cffd commit f8334d8
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 17 deletions.
4 changes: 2 additions & 2 deletions java/dagger/hilt/android/plugin/build.gradle
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
buildscript {
ext {
kotlin_version = "1.8.20"
kotlin_version = "1.9.0"
agp_version = System.getenv('AGP_VERSION') ?: "7.2.0"
ksp_version = "$kotlin_version-1.0.11"
ksp_version = "$kotlin_version-1.0.12"
pluginArtifactId = 'hilt-android-gradle-plugin'
pluginId = 'com.google.dagger.hilt.android'
}
Expand Down
6 changes: 3 additions & 3 deletions java/dagger/hilt/android/plugin/main/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ dependencies {
testImplementation 'junit:junit:4.12'
testImplementation 'com.google.truth:truth:1.0.1'
testImplementation 'org.javassist:javassist:3.26.0-GA'
testPluginCompile 'com.android.tools.build:gradle:7.1.2'
testPluginCompile 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.0'
testPluginCompile 'com.google.devtools.ksp:symbol-processing-gradle-plugin:1.8.0-1.0.9'
testPluginCompile "com.android.tools.build:gradle:$agp_version"
testPluginCompile "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
testPluginCompile "com.google.devtools.ksp:symbol-processing-gradle-plugin:$ksp_version"
}

// Configure the generating task of plugin-under-test-metadata.properties to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@ class BuildCacheTest(private val enableAggregatingTask: Boolean) {
val secondResult = secondGradleRunner.build()
val cacheableTasks: List<String> =
mutableListOf<String>().apply {
add(":checkDebugAarMetadata")
add(":checkDebugDuplicateClasses")
add(":compileDebugJavaWithJavac")
add(":compressDebugAssets")
add(":desugarDebugFileDependencies")
Expand All @@ -105,9 +103,6 @@ class BuildCacheTest(private val enableAggregatingTask: Boolean) {
add(":mergeProjectDexDebug")
add(":processDebugManifestForPackage")
add(":transformDebugClassesWithAsm")
add(":validateSigningDebug")
add(":writeDebugAppMetadata")
add(":writeDebugSigningConfigVersions")
}

val tasksFromCache =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ class GradleTestRunner(val tempFolder: TemporaryFolder) {
tempFolder.newFile("gradle.properties").apply {
writeText("""
android.useAndroidX=true
// TODO(b/296583777): See if there's a better way to fix the OOM error.
org.gradle.jvmargs=-XX:MaxMetaspaceSize=1g
""".trimIndent())
}
}
Expand Down
4 changes: 2 additions & 2 deletions javatests/artifacts/dagger-ksp/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
buildscript {
ext {
dagger_version = "LOCAL-SNAPSHOT"
kotlin_version = "1.8.0"
ksp_version = "1.8.0-1.0.9"
kotlin_version = "1.9.0"
ksp_version = "$kotlin_version-1.0.12"
junit_version = "4.13"
truth_version = "1.0.1"
}
Expand Down
2 changes: 1 addition & 1 deletion javatests/artifacts/dagger/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
buildscript {
ext {
dagger_version = "LOCAL-SNAPSHOT"
kotlin_version = "1.8.0"
kotlin_version = "1.9.0"
junit_version = "4.13"
truth_version = "1.0.1"
}
Expand Down
2 changes: 1 addition & 1 deletion javatests/artifacts/hilt-android/simple/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
buildscript {
ext {
dagger_version = 'LOCAL-SNAPSHOT'
kotlin_version = '1.8.0'
kotlin_version = '1.9.0'
agp_version = System.getenv('AGP_VERSION') ?: "7.1.2"
}
repositories {
Expand Down
6 changes: 3 additions & 3 deletions javatests/artifacts/hilt-android/simpleKotlin/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@

buildscript {
ext {
kotlin_version = '1.8.20'
ksp_version = '1.0.11'
kotlin_version = '1.9.0'
ksp_version = "$kotlin_version-1.0.12"
agp_version = System.getenv('AGP_VERSION') ?: "7.1.2"
}
repositories {
Expand All @@ -28,7 +28,7 @@ buildscript {
dependencies {
classpath "com.android.tools.build:gradle:$agp_version"
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
classpath "com.google.devtools.ksp:symbol-processing-gradle-plugin:$kotlin_version-$ksp_version"
classpath "com.google.devtools.ksp:symbol-processing-gradle-plugin:$ksp_version"
classpath 'com.google.dagger:hilt-android-gradle-plugin:LOCAL-SNAPSHOT'
}
}
Expand Down

0 comments on commit f8334d8

Please sign in to comment.