Add uid logging to tls_handshakes #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstreams https://r.android.com/2759365 This reverts commit 3a1331299cbcf99e9af7e069b95793fa6f536b3f. Reason for revert: try 3 of making this work (now with api level checking to avoid calling code that is not in R or S)
miguelaranda0
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreams https://r.android.com/2759365
This reverts commit 3a1331299cbcf99e9af7e069b95793fa6f536b3f.
Reason for revert: try 3 of making this work (now with api level checking to avoid calling code that is not in R or S)
Non-Android note: (1) TLS handshakes are not logged on other platforms and (2) On Android, an app's uid is a unique identifier for that app (each app gets its own) and not any kind of user data.