Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary gce serviceaccounts assertion #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zshihang
Copy link

GetInstanceScopes in the next couple lines have already implied the removed code.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 91.664% when pulling 27b6e22 on shihan9:master into 9659f28 on google:master.

if not self.GetServiceAccount(self.__service_account_name):
raise exceptions.ResourceUnavailableError(
'GCE credentials requested but service account '
'%s does not exist.' % self.__service_account_name)
if scopes:
scope_ls = util.NormalizeScopes(scopes)
instance_scopes = self.GetInstanceScopes()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that GetInstanceScopes handles a service account that doesn't exist correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants