Remove include of smart_holder_type_casters.h header #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rwgk
reviewed
Aug 1, 2024
| @@ -31,7 +31,6 @@ | |||
| #include "pybind11/include/pybind11/cast.h" | |||
| #include "pybind11/include/pybind11/detail/common.h" | |||
| #include "pybind11/include/pybind11/detail/descr.h" | |||
| #include "pybind11/include/pybind11/detail/smart_holder_type_casters.h" | |||
There was a problem hiding this comment.
Removing this private header makes you forward compatible (smart_holder branch before and after pybind/pybind11#5257 was merged).
If you don't care about backward compatibility (now or later) and also want to clean up:
Also remove all
- pybind11/include/pybind11/smart_holder.h includes
- macros you see here: https://github.com/pybind/pybind11/blob/48f25275c44d52d0ceade122e328dc1f2e48ef44/include/pybind11/smart_holder.h
As of 3cdecf7, you're only using the now obsolete PYBIND11_SMART_HOLDER_TYPE_CASTERS macro (37 in 15 files).
There was a problem hiding this comment.
Ok great, I'll do the cleanup in a follow-up PR (or internally) over the next week or so.
lanctot
added
the
imported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1256