Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dredd_command option #29

Merged
merged 3 commits into from
Jun 14, 2016
Merged

Add dredd_command option #29

merged 3 commits into from
Jun 14, 2016

Conversation

gonzalo-bulnes
Copy link
Owner

@gonzalo-bulnes gonzalo-bulnes commented Jun 9, 2016

As a developer
In order to be able to use Dredd::Rack with installations of Dredd that are not global
And, for example, use it inside a Docker container
I want to define a custom Dredd command
And I want that configuration to be used by all the Rake tasks I define

See #25

Allow Dredd to be installed locally.
@gonzalo-bulnes
Copy link
Owner Author

Does this look good to you @gottfrois?

@gottfrois
Copy link

It seems to do the job but why not a runner configuration directly? Since it's, in the end, a runner instance variable.

@gonzalo-bulnes
Copy link
Owner Author

I thought that the setting would be shared by all the runner instances within a project (much like the application definition), and that it would be convenient to avoid unnecessary repetition accross all the Rake tasks, for example. What do you think?

@gottfrois
Copy link

Yeah that makes sense.

@gonzalo-bulnes gonzalo-bulnes merged commit e062e52 into master Jun 14, 2016
@gonzalo-bulnes gonzalo-bulnes added this to the v0.9.0 milestone Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants