Refactor encapsulate the command-line interface #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Bundler dependency I might be wrong, but I think declaring bundler as a dependency is superfluous (e.g. its version is not locked in the Gemfile).
This reverts commit ae792ba due to failures in the Ruby 1.9.3 build on Travis CI. I'm not sure why the Ruby 1.9.3 build fails (while the Ruy 2.3.0 succeeds) but truth is this update can be omitted for now. See https://travis-ci.org/gonzalo-bulnes/dredd-hooks-ruby/builds/127012201
This refactoring should allow to start using Thor to build the CLI with minimal disruption. Using Thor would change the API (starting the server would require to dredd-hooks-ruby start instead of dredd-hooks-ruby) but would allow to build a properly documented CLI (dredd-hooks-ruby help and so on...) with minimal effort. See http://whatisthor.com
Minor refactor fix useless variable assignation
...provide default argument to 'Hash#fetch' instead.
Minor move informative output to STDOUT. Injecting the error and output steams allows to configure them and to write specs for their messages (eventually).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a developer
In order to be able to start the Ruby hooks server programatically
I want to keep all the Ruby hooks server business logic in a single directory
In order to to be able to improve its CLI independently
I want its CLI to be a first-class citizen among the code
See apiaryio#5
This refactoring should allow to start using Thor to build the CLI with minimal disruption.
Using Thor would change the API (starting the server would require to
dredd-hooks-ruby startinstead ofdredd-hooks-ruby) but would allow to build a properly documented CLI (dredd-hooks-ruby helpand so on...) with minimal effort.