-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor DRY the runner and DSL #6
Commits on Apr 25, 2016
-
To perform deeper refactoring a unit test suite will be useful. I like to make explicit the distinction between the specs which document the public API (tagged as :public) and those which are only refactoring guards and can be changed when necessary (tagged as :protected or :private depending on how stable they are intended to be). The 'spec:public' and 'spec:development' Rake tasks reflect that distinction.
Configuration menu - View commit details
-
Copy full SHA for bd3e847 - Browse repository at this point
Copy the full SHA bd3e847View commit details -
Minor fix missing link in testing documentation
Configuration menu - View commit details
-
Copy full SHA for 98af610 - Browse repository at this point
Copy the full SHA 98af610View commit details -
Refactor move from Runner module to instance
This will allow later to store the hooks content in the runner.
Configuration menu - View commit details
-
Copy full SHA for 20f4d22 - Browse repository at this point
Copy the full SHA 20f4d22View commit details
Commits on Apr 26, 2016
-
Refactor move hooks registration to Runner
Minor use parens in multiple arguments method calls Minor use parens in non-tivial method calls The DreddHooks::Methods exposes the public DSL of DreddHooks. As an interface, I would like it to be as simple as possible, and as immutable as possible. Since the DSL and the runner were closely related already, the latter seems to be a good place to store the hooks that need to be runned. Also, because the DSL is an interface for the runner, I prefer the dependency to go from the interface to the runner, that the contrary. Finally, I made the runner a Singleton because it was already unique when defined as a Module, and because it make trivial its retrieval from the DSL.
Configuration menu - View commit details
-
Copy full SHA for 3f4e1b2 - Browse repository at this point
Copy the full SHA 3f4e1b2View commit details -
Refactor isolate instance vars in registration methods
Isolating them will make clearer the dynamic method generation in the next DRYing step.
Configuration menu - View commit details
-
Copy full SHA for f8fdff9 - Browse repository at this point
Copy the full SHA f8fdff9View commit details -
Refactor isolate instance vars in run methods
Isolating them will make clearer the dynamic method generation in the next DRYing step.
Configuration menu - View commit details
-
Copy full SHA for 4015d08 - Browse repository at this point
Copy the full SHA 4015d08View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd63abd - Browse repository at this point
Copy the full SHA fd63abdView commit details
Commits on Apr 27, 2016
-
Configuration menu - View commit details
-
Copy full SHA for dfd7f9e - Browse repository at this point
Copy the full SHA dfd7f9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 126470e - Browse repository at this point
Copy the full SHA 126470eView commit details -
Refactor move instance variables initialization
The default values are clodely related to their setters anyway, so they can be generated in place at the price of very little duplication.
Configuration menu - View commit details
-
Copy full SHA for e5f8828 - Browse repository at this point
Copy the full SHA e5f8828View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a627db - Browse repository at this point
Copy the full SHA 1a627dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a980d68 - Browse repository at this point
Copy the full SHA a980d68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce2866 - Browse repository at this point
Copy the full SHA 9ce2866View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ff806a - Browse repository at this point
Copy the full SHA 0ff806aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21931de - Browse repository at this point
Copy the full SHA 21931deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54badf8 - Browse repository at this point
Copy the full SHA 54badf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d427b32 - Browse repository at this point
Copy the full SHA d427b32View commit details