Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for concurrent loader #18

Merged
merged 22 commits into from
Aug 24, 2023
Merged

Add support for concurrent loader #18

merged 22 commits into from
Aug 24, 2023

Conversation

sonnes
Copy link
Collaborator

@sonnes sonnes commented Aug 16, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.80% 🎉

Comparison is base (45bb106) 98.66% compared to head (e1a7788) 99.47%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   98.66%   99.47%   +0.80%     
==========================================
  Files          30       15      -15     
  Lines         601      189     -412     
==========================================
- Hits          593      188     -405     
+ Misses          8        1       -7     

see 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xload/options.go Show resolved Hide resolved
xload/async.go Outdated Show resolved Hide resolved
xload/load.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ajatprabha ajatprabha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some more testcases for the code paths which are not covered yet, test coverage is more important here as it deals heavily with reflection.

xload/load_test.go Show resolved Hide resolved
xload/async.go Outdated Show resolved Hide resolved
@ajatprabha ajatprabha force-pushed the xload/async branch 2 times, most recently from e67f343 to a8c5bd8 Compare August 22, 2023 13:03
@ajatprabha ajatprabha changed the title Draft: Add support for concurrent loader Add support for concurrent loader Aug 23, 2023
@sonnes sonnes merged commit 7c6d47c into main Aug 24, 2023
4 checks passed
@sonnes sonnes deleted the xload/async branch August 24, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants