refactor code

gojekfarm · Jul 8, 2024 · a7927ab · a7927ab
1 parent a168170
commit a7927ab
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/x/cli/cli.go b/x/cli/cli.go
@@ -142,16 +142,14 @@ func bindFlags(
 
 		if field.Type.Kind() == reflect.Struct {
 			nestedFlagPrefix := flag + "."
+			nestedEnvPrefix := env + "_"
 
 			flagPrefixDetails := strings.Split(field.Tag.Get("flag-prefix"), ",")
-			flagPrefix := flagPrefixDetails[0]
 
-			if flagPrefix != "" {
+			if flagPrefix := flagPrefixDetails[0]; flagPrefix != "" {
 				nestedFlagPrefix = flagPrefix + nestedFlagPrefix
 			}
 
-			nestedEnvPrefix := env + "_"
-
 			if envPrefix := field.Tag.Get("env-prefix"); envPrefix != "" {
 				nestedEnvPrefix = envPrefix + nestedEnvPrefix
 			}