Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoids clashing with globalPackageNames within generatePlugin #641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fedenusy
Copy link
Contributor

@fedenusy fedenusy commented Nov 11, 2019

Scenario:

  • Generating code via GeneratePlugin
  • Input proto located at a/proto/my_service.proto, with dependency located at b/proto/their_message.proto

Issue:

  • The GoType for TheirMessage my_field = 1; resolves to *proto.TheirMessage
  • Generated Go imports will include global proto library, as well as a 2nd entry that clashes: proto "github.com/them/b/proto"

This patch fixes the issue.

@fedenusy fedenusy changed the title Fixes generatePlugin clash with globalPackageNames Avoids clashes with globalPackageNames within generatePlugin Nov 11, 2019
@fedenusy fedenusy changed the title Avoids clashes with globalPackageNames within generatePlugin Avoids clashing with globalPackageNames within generatePlugin Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant