-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Update container package overview #1065
base: development
Are you sure you want to change the base?
doc: Update container package overview #1065
Conversation
pkg/gofr/container/container.go
Outdated
@@ -1,3 +1,6 @@ | |||
// The container package provides a centralized structure to manage common application-level concerns such as | |||
// logging, connection pools, and service management. This package is designed to facilitate the sharing and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also include data sources which comprises of different databases, pubsub, filesystem etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Also, I have a question about documentation in go. I saw that package container
is used in many files which made me wonder what is the best way to document such package? How do I choose which file to add documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container.go
is the central file which also has the container struct. So it is the best file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to add some references but couldn't figure out how exactly it works in godoc 😄
Supported data sources:
- Databases ([cassandra], [clickhouse], [mongo], [solr], [dgraph], [sql])
- Key value storages [redis] [kafka]
- Pub/Sub systems ([google], [kafka], [mqtt])
- File system [file]
Even more links to other packages generate false(not found) URL at least locally
Can you help me with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may refer to the following documentation
https://tip.golang.org/doc/comment#links
Description:
Checklist:
goimport
andgolangci-lint
.