Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix celesta plot_cells indexing bug #90

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Fix celesta plot_cells indexing bug #90

merged 3 commits into from
Sep 19, 2024

Conversation

CameronFRWatson
Copy link
Contributor

@CameronFRWatson CameronFRWatson commented Sep 18, 2024 •
edited
Loading

The final installment of bug fixes for CELESTA

This PR is related to

  • Adding a new tool
  • Updating an existing tool to a newer version
  • Fixing a bug or updating just the Galaxy wrapper of an existing tool
  • Making a change to the tools-mti repo, CI, or other misc. change

Provide details here

  • Prior marker info was not being correctly passed to celesta function in the plot_cells script
  • This has been fixed, and removed unnecessary arguments from plot_cells script
  • Also fixed test_size parameter to be properly passed thru to plot_cells function

Need to deprecate prior versions of CELESTA in the toolshed. There are now several version with bugs due to my various unfortunate bug findings

@CameronFRWatson CameronFRWatson marked this pull request as ready for review September 19, 2024 16:53
@alliecreason alliecreason merged commit 3645355 into main Sep 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alliecreason alliecreason alliecreason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CameronFRWatson @alliecreason