Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CELESTA: Fix cheetah variables to work with galaxy-22.01 #88

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

CameronFRWatson
Copy link
Contributor

Same problem as described in #67... I should've seen this one coming


This PR is related to

  • Adding a new tool
  • Updating an existing tool to a newer version
  • Fixing a bug or updating just the Galaxy wrapper of an existing tool
  • Making a change to the tools-mti repo, CI, or other misc. change

If updating an existing tool to a newer major version

  • I have updated the TOOL_VERSION token in the tool's macros file
  • I have reset the VERSION_SUFFIX to 0 in the tool's macros file

Provide details here

  • Removed unnecessary base options macro, brought them into the main celesta.xml file. Makes things a lot more readable
  • added hierarchical variable names so galaxy 22.01 can find variables (Example: $test_size to '${runmode.figure_options.test_size}')

@CameronFRWatson CameronFRWatson marked this pull request as ready for review September 5, 2024 22:48
Copy link
Member

@luke-c-sargent luke-c-sargent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@alliecreason alliecreason merged commit 1f02a76 into main Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants