Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose colormap param for Galaxy scimap stacked_barplot wrapper #85

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Expose colormap param for Galaxy scimap stacked_barplot wrapper #85

merged 5 commits into from
Jul 30, 2024

Conversation

CameronFRWatson
Copy link
Contributor

Currently, the scimap stacked barplot galaxy tool uses only default colormaps for y-axis categories. This can lead to poor color discrimination between categories depending on the number of categories being plotted. To fix this, this PR adds a colormap param so users can pick their colors more flexibly.

This PR is related to

  • Adding a new tool
  • Updating an existing tool to a newer version
  • Fixing a bug or updating just the Galaxy wrapper of an existing tool
  • Making a change to the tools-mti repo, CI, or other misc. change

If updating an existing tool to a newer major version

  • I have updated the TOOL_VERSION token in the tool's macros file
  • I have reset the VERSION_SUFFIX to 0 in the tool's macros file

Provide details here

  • Incremented VERSION_SUFFIX to 2

luke-c-sargent
luke-c-sargent approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@luke-c-sargent luke-c-sargent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

alliecreason
alliecreason approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@alliecreason alliecreason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing. Everything looks good.

@alliecreason alliecreason merged commit c39cea5 into main Jul 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke-c-sargent luke-c-sargent luke-c-sargent approved these changes

@alliecreason alliecreason alliecreason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CameronFRWatson @luke-c-sargent @alliecreason