Ashlar version update #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_format; removed pyramid upgrade script; added stitch_alpha; changed expected output size
|
@bgruening We updated this tool from 1.14 to 1.18. Given that the tool version is changing, should we also increment the VERSION_SUFFIX for the wrapper (from 1 to 2)? Or because it's a new version of the tool itself, the wrapper version suffix would reset to 1? Thank you! |
|
You can reset the SUFFIX back to 0 if you have a new major version. Can you also please look at the linter warnings? |
|
Thanks @bgruening for the quick response! I addressed the lint warnings, and will do the same for the other tools as we go through and make updates |
bgruening
approved these changes
Feb 9, 2024
|
Thanks @CameronFRWatson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASHLAR version update to 1.18.0. See tool repo: https://github.com/labsyspharm/ashlar/releases/tag/v1.18.0