-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.2 beta 1 and publish release notes #728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work so far! I reviewed the content and made some suggestions.
I know I noted on a few PRs that I wanted to say something in particular in the release post, so I'll go back and look for those notes now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, very well done on these release notes. The document is enjoyable to read and must have taken you ages to write!
Thanks for reviews! Most of it should be addressed now.
Just 2-3 days 🙃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more suggestions. One for the attribute compression PR and another dealing with CPUParticles
I made the changes, but GitHub seems to be experiencing issues and is stuck processing pushed commits. |
f1fc9b8
to
64f6bc7
Compare
Fixed it! I left the latest change as a separate commit for clarity. |
I'd like to suggest another image to illustrate the GDScript highlighting changes. The previous image is outdated, it highlights The image may be too wide, but we can remove the Godot 2 theme (middle image) and leave only the default and the light themes. |
c25b149
to
38c5ed0
Compare
It looks more interesting with 3 sections, thanks! |
38c5ed0
to
6bcdf56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass down to the Editor section (included).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review pass down to GUI (included). Have to step out for 30 min, I'll continue then.
51483fe
to
5cb642a
Compare
810ca7c
to
a4755ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This here is a damn fine write-up :) Well done Yuri!
Here's my last review pass.
ed002a8
to
fbc79b7
Compare
Co-authored-by: Clay John <[email protected]>
Thanks for reviews, everyone! |
Drafting as the release is not ready yet, but this can be reviewed for content and grammar.