Bugfix - Vector3::sign gives incorrect results due to i32 conversion #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarwin
force-pushed
the
bugfix/fix_vector_sign
branch
3 times, most recently
from
f039636
to
053c5d4
Compare
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-865 |
Bromeon
reviewed
Aug 19, 2024
| #[test] | ||
| fn sign() { | ||
| let vector = Vector3::new(0.2, -0.5, 0.0); | ||
| assert_eq_approx!(vector.sign(), Vector3::new(1., -1., 0.)); |
There was a problem hiding this comment.
This could be assert_eq!, no? Since the numbers can be precisely represented...
In other places too
Comment on lines
487
to
492
| fn f(x: $Scalar) -> $Scalar { | ||
| let r = x.partial_cmp(&(0 as $Scalar)).unwrap_or_else(|| panic!("Vector component {x} isn't signed!")); | ||
| match r { | ||
| Ordering::Equal => 0 as $Scalar, | ||
| Ordering::Greater => 1 as $Scalar, | ||
| Ordering::Less => -1 as $Scalar, |
There was a problem hiding this comment.
Maybe while at it, rename x to c for component. It's a bit misleading otherwise.
Yarwin
force-pushed
the
bugfix/fix_vector_sign
branch
from
053c5d4
to
6d77c68
Compare
Bromeon
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #864