Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account credentials #1064

Merged

Conversation

DaanRademaker
Copy link
Collaborator

@DaanRademaker DaanRademaker commented Jan 8, 2024

  • Create new function with account client which is used for account level api's
  • Refactor credential code to use databricks-sdk
  • Write unittest for python for credentials code
  • Write jest tests for credentials

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8ea9233) 63.15% compared to head (1cce93b) 64.31%.

Files Patch % Lines
aws-lambda/src/databricks_cdk/utils.py 40.00% 3 Missing ⚠️
aws-lambda/src/databricks_cdk/resources/handler.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1064      +/-   ##
==========================================
+ Coverage   63.15%   64.31%   +1.16%     
==========================================
  Files          38       38              
  Lines        1919     1903      -16     
==========================================
+ Hits         1212     1224      +12     
+ Misses        707      679      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan1elt0m dan1elt0m self-requested a review January 8, 2024 15:08
@DaanRademaker DaanRademaker merged commit ca37152 into godatadriven:main Jan 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants