Updates #28
Open
Updates #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
requested changes
Oct 22, 2021
| @@ -6,8 +6,6 @@ func injectMessageReactions(r *handler.MessageActions) { | |||
| r.HandleReaction("bbq", "bbqgopher") | |||
| r.HandleReaction("ghost", "ghost") | |||
| r.HandleReaction("spacex", "rocket") | |||
| r.HandleReaction("buffalo", "gobuffalo") | |||
| r.HandleReaction("gobuffalo", "gobuffalo") | |||
There was a problem hiding this comment.
I'd rather see this be a HandleReactionRand since it's for things we may not want to happen all the time.
There was a problem hiding this comment.
I think we can get rid of it. If someone wants it back, they can request it.
cmd/consumer/consumer.go
Outdated
| @@ -107,7 +96,7 @@ func runServer(cfg config.C, logger zerolog.Logger) error { | |||
|
|
|||
| cCache := cache.NewChannel(rc) | |||
|
|
|||
| // set up the workqueue | |||
| // set up the work queue | |||
There was a problem hiding this comment.
My language choice here was intentional.
| @@ -201,7 +185,6 @@ func newHTTPTransport() *http.Transport { | |||
| DialContext: (&net.Dialer{ | |||
| Timeout: 10 * time.Second, | |||
| KeepAlive: 30 * time.Second, | |||
| DualStack: true, | |||
There was a problem hiding this comment.
DualStack is deprecated, see https://pkg.go.dev/net#Dialer.DualStack
| @@ -227,7 +226,6 @@ func injectMessageResponses(ma *handler.MessageActions) { | |||
| `These articles will explain how to organize your Go packages:`, | |||
| `- <https://rakyll.org/style-packages/>`, | |||
| `- <https://medium.com/@benbjohnson/standard-package-layout-7cdbc8391fc1#.ds38va3pp>`, | |||
| `- <https://peter.bourgon.org/go-best-practices-2016/#repository-structure>`, | |||
There was a problem hiding this comment.
I think this is still a good resource. Why the removal?
There was a problem hiding this comment.
We have resources for this already, which explain the problem and solution in a similar way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small updates