fix: temporary files not being correctly deleted (#969)

* fix: use os.Remove for tmpFile * fix: delete double file remove --------- Co-authored-by: Felipe Martin <[email protected]>
go-shiori · Aug 28, 2024 · 2bcb890 · 2bcb890
1 parent a4304bc
commit 2bcb890
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/internal/core/processing.go b/internal/core/processing.go
@@ -166,7 +166,7 @@ func ProcessBookmark(deps *dependencies.Dependencies, req ProcessRequest) (book
 		if err != nil {
 			return book, false, fmt.Errorf("failed to create temp archive: %v", err)
 		}
-		defer deps.Domains.Storage.FS().Remove(tmpFile.Name())
+		defer os.Remove(tmpFile.Name())
 
 		archivalRequest := warc.ArchivalRequest{
 			URL:         book.URL,
@@ -178,7 +178,6 @@ func ProcessBookmark(deps *dependencies.Dependencies, req ProcessRequest) (book
 
 		err = warc.NewArchive(archivalRequest, tmpFile.Name())
 		if err != nil {
-			defer os.Remove(tmpFile.Name())
 			return book, false, fmt.Errorf("failed to create archive: %v", err)
 		}