fix: fix memory pools & race issues #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 93.30% 92.53% -0.77%
==========================================
Files 23 23
Lines 3839 3150 -689
==========================================
- Hits 3582 2915 -667
+ Misses 203 154 -49
- Partials 54 81 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fredbi
changed the title
* fixes
* a memory leak with recycled *Result in schema_props.go was causing
some invalid results when GC is under pressure (seen on go-swagger test)
* refactored schema props to isolate anyOf, oneOf, allOf, etc.
* made the validation logic a little clearer to follow
* fixed leaks with unreleased allocated Results
* ensured that child validators for schemaPropsValidator cannot be
reused after they are exhausted
* ensured that recyclable results are redeemed in all cases in default
and example validators
* with go1.22, the race detector figured a race condition when expanding
the swagger schema for parameters (spec.go)
* before iterating over parameters to validate the swagger schema for
a parameter, deep clone the schema from the root spec. This is
performed once for a spec, so the perf impact should be negligible
* tests
* added test for go-swagger fixture #2866, which exhibits the failure
with the highest probability
* added a debug version of the pools (build with the "validatedebug"
build tag) to assert more thorough checks of the correctness of the
pools usage
Signed-off-by: Frederic BIDON <[email protected]>
fredbi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
a memory leak with recycled *Result in schema_props.go was causing
some invalid results when GC is under pressure (seen on go-swagger test)
reused after they are exhausted
and example validators
with go1.22, the race detector figured a race condition when expanding
the swagger schema for parameters (spec.go)
a parameter, deep clone the schema from the root spec. This is
performed once for a spec, so the perf impact should be negligible
tests
with the highest probability
build tag) to assert more thorough checks of the correctness of the
pools usage
Signed-off-by: Frederic BIDON [email protected]