Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
max_price_impact
parameter to KellyBettingStrategy #433Add
max_price_impact
parameter to KellyBettingStrategy #433Changes from 37 commits
4bfc702
2c8389a
c9c198a
5333d1d
195f019
fd741d4
f7dc54b
9b6aaa7
337df5e
c17790d
a6804a3
ac99ce1
bda388b
752c3be
6c67f15
f6a7499
0a01259
7a04ea6
d13f235
55d90a6
4b1a6d2
297a0bf
5ba66b5
572b943
ba2afcd
dabcc23
1a3f362
625d012
5e04adf
3ccb430
b7cd215
321cff8
efa1909
06be0d6
79fca0c
04ec90d
b8884de
6b7b6a7
83349d4
22e4028
6f014a6
d3f5c04
74d524e
8cd4818
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @evangriffiths removed this in the other PR because it was bloating disk too much? (btw sorry for spamming your disk Evan 😄 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. What's the use of saving them? I don't mind having them if they're useful, but maybe in a subdirectory which is .gitignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown file shows it aggregated per strategy (total profit, total ROI, etc.). These per-strategy files are good for finding out which are the bets that made it unprofitable.
For example, these sheets are imported out of these CSVs, it was eye-opening for me to see that the agent is profitable up to last 4 bets that have catastrophic effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see - reckless of me to just remove then. Well now they're back!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, will keep them here then.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.