Two suggested fixes for the tx-indexer Getting Started #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only takes a moment to get that this is needed, but that is a moment lost.
This doesn't work in the graphql playground unless I change "message" to "messages".
Seems to be a typo, should be "messages"
moul
approved these changes
Sep 2, 2024
zivkovicmilos
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into these as I was doing the take-home assignment.
1: cd tx-indexer before running make:
This only cost me a few moments before I realized what to do, but this is a few moments best saved.
2: filter "messages" not "message" : this doesn't work correctly as provided and should be fixed either in the example or in the implementation.