feat: add Matija's Homepage realm to examples #2916
+452
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matijamarjanovic
requested review from
ltzmaxwell and
gfanton
and removed request for
a team
matijamarjanovic
changed the title
jefft0
added
the
review team
matijamarjanovic
changed the title
notJoon
suggested changes
Oct 10, 2024
Comment on lines
+9
to
+10
| main std.Address // tony's main address | ||
| backup std.Address // backup address |
There was a problem hiding this comment.
these two variable's names are seems ambiguous. Could you update their names? like mainAddr
There was a problem hiding this comment.
Hi, please see fix in this commit: 16529d3
|
|
||
| func SetAddress(a std.Address) error { | ||
| if !a.IsValid() { | ||
| return errors.New("config: invalid address") |
There was a problem hiding this comment.
error messages are repeated (invalid arress and unauthorized). please make them as constant.
There was a problem hiding this comment.
Hi, pleas see fix im this commit: 15e15a2
| return backup | ||
| } | ||
|
|
||
| func SetAddress(a std.Address) error { |
There was a problem hiding this comment.
very niptick: consider change parameter name a to more concrete name.
There was a problem hiding this comment.
Hi, please see fix here: ef98d67
…ble's names are seems ambiguous. Could you update their names? like mainAddr)
… on PR - error messages are repeated (invalid arress and unauthorized). please make them as constant.)
…mment on PR - very niptick: consider change parameter name a to more concrete name.)
|
Thank you for your insights @notJoon. I've fixed the issues, please let me know if I can make anything more appropriate. |
notJoon
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds a new realm example to the Gno
examplesrepository—Matija's Homepage. It showcases a personal homepage built on the Gno chain where users can interact by voting with GNOT tokens to change the page's color. The more tokens users send, the greater influence they have on the color scheme, providing an interactive and dynamic experience.Key Features
Tools & Technologies
Why this is valuable
This example highlights the possibilities of personal realms on Gno, showing how users can create unique and interactive profiles. It’s a fun and approachable entry point for anyone new to Gno development, while also demonstrating the platform's flexibility and potential for creative expression.