Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verifySignature function #2776

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Villaquiranm
Copy link
Contributor

@Villaquiranm Villaquiranm commented Sep 9, 2024

related to #2777

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.97%. Comparing base (912a5db) to head (06d4232).

Files with missing lines Patch % Lines
gnovm/stdlibs/std/native.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2776   +/-   ##
=======================================
  Coverage   60.97%   60.97%           
=======================================
  Files         564      564           
  Lines       75273    75307   +34     
=======================================
+ Hits        45897    45918   +21     
- Misses      26008    26018   +10     
- Partials     3368     3371    +3     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 67.92% <ø> (ø)
gnovm 65.81% <88.23%> (+0.02%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.07% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Villaquiranm Villaquiranm force-pushed the feat/verifySignature branch 3 times, most recently from 76ec144 to 74ed842 Compare September 11, 2024 06:56
@Kouteki Kouteki added the review team PRs that should be reviewed first by the review team or external contributors label Oct 3, 2024
@notJoon
Copy link
Member

notJoon commented Oct 10, 2024

CI failed. could you please check and fix this?

@Villaquiranm
Copy link
Contributor Author

Villaquiranm commented Oct 11, 2024

CI failed. could you please check and fix this?

I think it is ok just one does not want to finish do not know why
@notJoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related review team PRs that should be reviewed first by the review team or external contributors
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants