Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly fail when ssl setup fails in socket_init #4402

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

explicitly fail when ssl setup fails in socket_init #4402

wants to merge 1 commit into from

Commits on Aug 23, 2024

  1. explicitly fail when ssl setup fails in socket_init 

    Currently in socket_init(), it doesn't check the ret code on
ssl_setup_connection_params() call. the initialization appears
successful but the transport is not usable, ssl handshake all fails.

There are many failure scenarios like cert/key/ca file absence, or
cert/key mismatch, that cause the ssl setup failing.

It's better to fail the initialization explicitly so that we can
discover the problem much earlier. There are so many

Signed-off-by: Jiankun Yu <[email protected]>
    @jiankyu
    jiankyu committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0122321 View commit details
    Browse the repository at this point in the history