Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪Project API Tryout - Fluorescence example 🚧 #83

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsnel
Copy link
Member

@jsnel jsnel commented Nov 8, 2022

Porting the pyglotaran-examples to project API:

  • Converted the "study_fluorescence " example into a project API example

Converted the "study_fluoresnce" example into a project API example
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 8, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 3.00 ⭐ 3.00 ⭐ 0.00
Method Length 318.00 ⛔ 318.00 ⛔ 0.00
Working memory 18.00 ⛔ 18.00 ⛔ 0.00
Quality 38.82% 😞 38.82% 😞 0.00%
Other metrics Before After Change
Lines 83 83 0
Changed files Quality Before Quality After Quality Change
pyglotaran_examples/study_fluorescence/target_analysis_script.py 38.82% 😞 38.82% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!


if __name__ == "__main__":
project_file = Path(".") / "project.gta"
project_folder = project_file.parent

Check notice

Code scanning / CodeQL

Unused global variable

The global variable 'project_folder' is not used.
@joernweissenborn
Copy link
Member

This is only refactored to have projects file structure, but it is not using the project object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants