Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove operations pull completed tokens from txn-queue #301

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Commits on Nov 19, 2018

  1. Configuration menu
    Copy the full SHA
    81681e4 View commit details
    Browse the repository at this point in the history
  2. (wip) Remove on a document can pull the queue, too.

    We are directly inserting the Queue, but instead of just blindly copying
    what was in the old document, apply the $pullAll that we would have
    applied if this were an Update. Because we are creating the stash
    document from scratch, we don't need to ask Mongo to do the work.
    jameinel committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    a8a365a View commit details
    Browse the repository at this point in the history
  3. Comment on why we aren't Pulling during Insert.

    Essentially, we don't have to do both Insert and Remove, because one of
    them must have been done in order to do the other.
    
    This way, a series of only Insert and Remove operations won't cause the
    txn-queue to get out of hand.
    jameinel committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    8141feb View commit details
    Browse the repository at this point in the history
  4. Proper fix, including on Insert.

    It turns out that I missed we had just reread the document as part of
    the 'add txn-insert' or 'add txn-remove' to the document. That gives us
    an updated txn-queue that needs to be handled. Since we are now cleaning
    directly on the txn-queue instead of the cached queue docs, go ahead and
    do it on both Insert and Remove.
    jameinel committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    4485ffa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    98832d7 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. Configuration menu
    Copy the full SHA
    0ca7a4d View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2018

  1. Configuration menu
    Copy the full SHA
    2a46c73 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Configuration menu
    Copy the full SHA
    226ef5b View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. Configuration menu
    Copy the full SHA
    6559e40 View commit details
    Browse the repository at this point in the history