forked from domodwyer/mgo
-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove operations pull completed tokens from txn-queue #301
Open
jameinel
wants to merge
9
commits into
globalsign:development
Choose a base branch
from
jameinel:txn-globalsign-remove-prunes-queue
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove operations pull completed tokens from txn-queue #301
jameinel
wants to merge
9
commits into
globalsign:development
from
jameinel:txn-globalsign-remove-prunes-queue
Commits on Nov 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 81681e4 - Browse repository at this point
Copy the full SHA 81681e4View commit details -
(wip) Remove on a document can pull the queue, too.
We are directly inserting the Queue, but instead of just blindly copying what was in the old document, apply the $pullAll that we would have applied if this were an Update. Because we are creating the stash document from scratch, we don't need to ask Mongo to do the work.
Configuration menu - View commit details
-
Copy full SHA for a8a365a - Browse repository at this point
Copy the full SHA a8a365aView commit details -
Comment on why we aren't Pulling during Insert.
Essentially, we don't have to do both Insert and Remove, because one of them must have been done in order to do the other. This way, a series of only Insert and Remove operations won't cause the txn-queue to get out of hand.
Configuration menu - View commit details
-
Copy full SHA for 8141feb - Browse repository at this point
Copy the full SHA 8141febView commit details -
Proper fix, including on Insert.
It turns out that I missed we had just reread the document as part of the 'add txn-insert' or 'add txn-remove' to the document. That gives us an updated txn-queue that needs to be handled. Since we are now cleaning directly on the txn-queue instead of the cached queue docs, go ahead and do it on both Insert and Remove.
Configuration menu - View commit details
-
Copy full SHA for 4485ffa - Browse repository at this point
Copy the full SHA 4485ffaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98832d7 - Browse repository at this point
Copy the full SHA 98832d7View commit details
Commits on Nov 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0ca7a4d - Browse repository at this point
Copy the full SHA 0ca7a4dView commit details
Commits on Nov 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 2a46c73 - Browse repository at this point
Copy the full SHA 2a46c73View commit details
Commits on Dec 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 226ef5b - Browse repository at this point
Copy the full SHA 226ef5bView commit details
Commits on Jan 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6559e40 - Browse repository at this point
Copy the full SHA 6559e40View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.