Report non-byte aligned bit array patterns as compile errors for JS target #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-viney
force-pushed
the
js_byte_alignment_compile_error
branch
from
d4ddb08
to
507b41d
Compare
lpil
reviewed
Aug 14, 2024
richard-viney
force-pushed
the
js_byte_alignment_compile_error
branch
2 times, most recently
from
da8c649
to
c6710e4
Compare
|
Tests have been added, should be good to go. Pre-existing tests cover the changes made in |
|
I believe the CI failure is caused by minor linter incompatibilities with Rust 1.81 that was released a couple of days ago, not by the changes in this PR. |
richard-viney
force-pushed
the
js_byte_alignment_compile_error
branch
from
c6710e4
to
202d30b
Compare
lpil
force-pushed
the
js_byte_alignment_compile_error
branch
from
202d30b
to
f5472b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three small changes:
sizedInt()in the JS prelude that avoids a.reverse()callCan split these out to separate PRs if that's preferred