Add action to move imports to top of module #3413
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giacomocavalieri
force-pushed
the
fix-3186
branch
from
e6a47c2
to
8843508
Compare
lpil
reviewed
Jul 19, 2024
|
|
||
| pub fn main() {} | ||
|
|
||
| import result |
There was a problem hiding this comment.
What happens if the imports are lower but in groups? Do the groups get preserved?
What about comments?
There was a problem hiding this comment.
Mmh this is quite tricky, basically I'd have to reimplement part of the pretty printer here but I'm not a fan of that... I'll have to think a bit more how to approach this
giacomocavalieri
force-pushed
the
fix-3186
branch
from
2b6b8ee
to
b42ff26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3186
I also moved this action and the tuple one to their own module because it was starting to feel a bit overwhelming to have everything in the actions module. If you don't like this I can put everything back to just that file though!