Don't try to apply Mark-of-the-Web to nonexistent files

Trying to apply it to a nonexistent file is unacceptable, as it may unexpectedly create such a file. Closes qbittorrent#21440.
glassez · Oct 3, 2024 · 1f2faee · 1f2faee
1 parent b5b34c9
commit 1f2faee
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/base/utils/os.cpp b/src/base/utils/os.cpp
@@ -271,6 +271,11 @@ Path Utils::OS::windowsSystemPath()
 #if defined(Q_OS_MACOS) || defined(Q_OS_WIN)
 bool Utils::OS::applyMarkOfTheWeb(const Path &file, const QString &url)
 {
+    // Trying to apply this to a non-existent file is unacceptable,
+    // as it may unexpectedly create such a file.
+    if (!file.exists())
+        return false;
+
     Q_ASSERT(url.isEmpty() || url.startsWith(u"http:") || url.startsWith(u"https:"));
 
 #ifdef Q_OS_MACOS