Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an autofix for lang-go #1117

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Add an autofix for lang-go #1117

merged 5 commits into from
Oct 4, 2023

Conversation

filiptronicek
Copy link
Member

Creates the workflow so that Go is updated automatically

@gitpod-io
Copy link

gitpod-io bot commented Jul 11, 2023

@filiptronicek filiptronicek self-assigned this Jul 11, 2023
@filiptronicek
Copy link
Member Author

filiptronicek commented Jul 11, 2023

Need to figure out how to add gvm to make it available to autofix

@filiptronicek
Copy link
Member Author

@jankeromnes regarding this PR, would you happen to know how we can add additional tools that will be made available to autofix? 🙏

@jankeromnes
Copy link
Contributor

jankeromnes commented Jul 17, 2023

@filiptronicek Hey, very nice work! 💯 Autofix currently runs from an old CircleCI job (from before I joined Gitpod). I've been considering migrating it to a GitHub Action, but meanwhile, this is what the CI job uses:

  • Based on gitpod/workspace-full
  • Has these tools on top:
            brew install hub
            git clone https://github.com/pyenv/pyenv-update.git $(pyenv root)/plugins/pyenv-update
            pip install codespell
            npm install -g autofix
             bash < <(curl -s -S -L https://raw.githubusercontent.com/moovweb/gvm/master/binscripts/gvm-installer)

So, gvm should now be available in future Autofix runs!

@filiptronicek
Copy link
Member Author

Thanks so much for looking into it so quickly, @jankeromnes 🙏.

@filiptronicek filiptronicek marked this pull request as ready for review October 4, 2023 08:49
@filiptronicek filiptronicek requested a review from a team as a code owner October 4, 2023 08:49
@filiptronicek filiptronicek merged commit 0887ce3 into main Oct 4, 2023
5 checks passed
@filiptronicek filiptronicek deleted the ft/go-autofix branch October 4, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD enhancement New feature or request lang: go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants