Use createTelemetryLogger api #11
Conversation
jeanp413
force-pushed
the
jp/intermediate-eagle
branch
from
f5110c0
to
b3b2554
Compare
| const idx = eventName.indexOf('/'); | ||
| eventName = eventName.substring(idx + 1); | ||
|
|
||
| const properties = data ?? {}; |
There was a problem hiding this comment.
| const properties = data ?? {}; | |
| const properties = mixin(data ?? {}, commonProperties); |
common properties are missing
There was a problem hiding this comment.
they should be already there as they are added internally by vscode , that's should only needed for sendErrorData 🤔
There was a problem hiding this comment.
There was a problem hiding this comment.
But you see the screenshot, it fixed (version / name are correct) after I mix the common properties
There was a problem hiding this comment.
So the common properties are missing in additionalCommonProperties ? Or this is expected to not send properties like extversion? Or it won't work only with debug mode?
There was a problem hiding this comment.
ah wait you tested from sources? then that's expected, it's because vscode will do validation for files in extension folder and telemetryService is in a different folder gitpod-shared, we should test it using webpacked version, i.e. in preview env using updated gitpod-web image tag
mustard-mh
force-pushed
the
jp/intermediate-eagle
branch
from
a815641
to
b3b2554
Compare
|
Tested in preview env 👍 |
Description
Use createTelemetryLogger api
How to test