Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update_existing logic #210

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: update_existing logic #210

merged 1 commit into from
Aug 30, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Aug 30, 2024

Pull Request

fixes #208

Proposed Changes

Simplify and correct the handling of the update_existing parameter when checking for existing Dependabot configuration files. The most important changes include removing the update_existing parameter from the check_existing_config function and updating the surrounding logic accordingly. This should result in fixing the situation described in #208. I did have to remove a test now that the update_existing parameter is no longer used in the check_existing_config function.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

Signed-off-by: Zack Koppert <[email protected]>
Copy link
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice and simple.

@zkoppert zkoppert merged commit d6e090a into main Aug 30, 2024
29 checks passed
@zkoppert zkoppert deleted the fix-update-existing-logic branch August 30, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants