Merge pull request #50 from ymzEmre/main

Fix check all behavior with disabled inputs #21
github · May 16, 2024 · cee129b · cee129b
2 parents 02306fe + e5535ad
commit cee129b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -10,7 +10,7 @@ export default function subscribe(container: HTMLElement): Subscription {
   container.addEventListener('change', onChange)
 
   function setChecked(target: Element, input: HTMLElement, checked: boolean, indeterminate = false): void {
-    if (!(input instanceof HTMLInputElement)) return
+    if (!(input instanceof HTMLInputElement) || input.disabled) return
 
     input.indeterminate = indeterminate
     if (input.checked !== checked) {

diff --git a/test/test.js b/test/test.js
@@ -78,4 +78,17 @@ describe('check-all', function () {
     assert(checkboxes[3].checked)
     assert(checkAll.indeterminate)
   })
+
+  it('checks all without disabled', function () {
+    const checkAll = document.querySelector('[data-check-all]')
+    const count = document.querySelector('[data-check-all-count]')
+    const checkboxes = document.querySelectorAll('[data-check-all-item]')
+    checkboxes[1].disabled = true
+    checkboxes[2].disabled = true
+    checkboxes[3].disabled = true
+    checkAll.click()
+    assert.equal(count.textContent, '1')
+    assert.equal(document.querySelectorAll('[data-check-all-item]:checked').length, 1)
+    assert.notOk(checkAll.indeterminate)
+  })
 })