Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update HTMLDialogElement constructor versions for Opera/Safari #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update HTMLDialogElement constructor versions for Opera/Safari #63

wants to merge 1 commit into from
+1 −1

Conversation

erkde
Copy link

@erkde erkde commented Oct 6, 2024

Hi, just came across this table via your engineering blog, looks like these versions just got switched around?

Before

Screenshot 2024-10-06 at 10 30 15 am

After

Screenshot 2024-10-06 at 10 58 18 am

HTMLDialogElement Constructor

@erkde erkde requested a review from a team as a code owner October 6, 2024 00:16
keithamus
keithamus approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! Thanks again for the contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@HumzahChoudry HumzahChoudry Awaiting requested review from HumzahChoudry HumzahChoudry is a code owner automatically assigned from github/web-systems-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erkde @keithamus