Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve password validation #164

Conversation

FroggyRocky
Copy link
Contributor

improve password validation: min 8 chars in total, min one uppercase, min one lowercase letters and min one number and min one special character. Validation integrated into handleSubmit function.
Additionally, I added styles to errors to be rendered in the next line, in column with input fields, not inline with input fields as the errors might be long this time and it looks not very good if errors are inline with the input fields

@gitfrosh
Copy link
Owner

@FroggyRocky Thank you for your hard work on this issue! It's much appreciated. However, it looks like a unit test is currently failing. Could you please take a look at it when you have a moment?

@MateuszKikmunter
Copy link
Collaborator

Also PR contains only frontend changes, what about backend validation? Then we also need to consider existing users and existing passwords.

Copy link
Collaborator

@MateuszKikmunter MateuszKikmunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing for these changes. Can you please take a look at it when you some time @FroggyRocky ? Also would you consider adding backend validation?

@FroggyRocky
Copy link
Contributor Author

right on! Will do, thanks!

@FroggyRocky
Copy link
Contributor Author

@MateuszKikmunter and what about existing users? I didn't get the point, since I implemented additional validation only for password in sign-up, not login. I will implement the validation on the backend only for register controller as well. Existing users should be fine, no?

@MateuszKikmunter
Copy link
Collaborator

@MateuszKikmunter and what about existing users? I didn't get the point, since I implemented additional validation only for password in sign-up, not login. I will implement the validation on the backend only for register controller as well. Existing users should be fine, no?

Makes sense, I thought that you'll add it for the log in action too but having it only for register is sufficient. Thanks for the PR!

@MateuszKikmunter MateuszKikmunter merged commit ec1f2dc into gitfrosh:beta Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants