Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#17) updated TargetFramework to net6.0-windows7.0 #18
base: master
Are you sure you want to change the base?
(#17) updated TargetFramework to net6.0-windows7.0 #18
Changes from 1 commit
f318055
6388295
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need these two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Plugin Manager we have
System.ComponentModel.Composition
with6.0.0
and that's enough. I think we had some problems when referencing VS MEF in Plugin Manager.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. We can only use versions used in the main app: https://github.com/gitextensions/gitextensions/blob/master/Packages.props#L18-L20
But since we'd be referencing the main app, I'm curious why we need these here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, we just reference main app specific dlls. It doesn't add indirect references to the build, right? And so we need some MEF to be able compile the plugin dll.
Maybe could add all/some package reference from main app to the GitExtensions.Extensibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I "only" copied those from the
Gerrit
plugin. I was wondering, though, why it was those instead ofSystem.ComponentModel.Composition
.I'm perfectly happy to change those for something better. Referencing
Microsoft.VisualStudio.*
feels weird.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove these completely unless we have a strong justification. In case we do, we should document it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a section to readme under Good Practices stating that
GitExtensionsReferenceVersion
used for local development should be synchronized withGitExtensions.Extensibility
package version, so local dev loop and published package targets the same version of Git Extensions.It's out of scope of this PR, so if you don't want to write it, I can do it in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so good on words, but I'll give it a try.I'm uncertain if I get what you mean, here.
GitExtensions.Extensibility
"only" ensures a local copy of Git Extensions exists for local development. It "only" provides thepreBuild
and thepostBuild
targets, does it not?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also adds a dependency in the built nuget package and we use this dependency to validate that the package is intended for the current main app version (we still have gaps in this area, but in general 0.3 means targeting Git Extensions v4).
As we don't have a stable API yet, you typically need to "hack" into what Git Extensions give you in the current plugin API, and so it is important to build against "similar" version that you the plugin to run in (most of my plugins needs at least recompilation between main app version upgrades).
Using "latest" can be dangerous, because it may download even preview version.