-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#17) updated TargetFramework to net6.0-windows7.0 #18
Open
nils-a
wants to merge
2
commits into
gitextensions:master
Choose a base branch
from
nils-a-forks:bugfix/GH-17
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 8 additions & 4 deletions
12
src/GitExtensions.PluginTemplate/GitExtensions.PluginTemplate.csproj.user
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,12 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <GitExtensionsDownloadPath>..\..\..\gitextensions.shared</GitExtensionsDownloadPath> <!-- path is relative to $(ProjectDir) --> | ||
| <GitExtensionsReferenceVersion>latest</GitExtensionsReferenceVersion> <!-- 'latest' or 'v3.1' (= tag from GitHub releases) or 'v3.1.0.5877' (= build number from AppVeyor)--> | ||
| <GitExtensionsReferenceSource>GitHub</GitExtensionsReferenceSource> <!-- 'GitHub' or 'AppYevor' --> | ||
| <GitExtensionsPath></GitExtensionsPath> <!-- for local builds (no download) --> | ||
| <!-- path is relative to $(ProjectDir) --> | ||
| <GitExtensionsDownloadPath>..\..\..\gitextensions.shared</GitExtensionsDownloadPath> | ||
| <!-- 'latest' or 'v3.1' (= tag from GitHub releases) or 'v3.1.0.5877' (= build number from AppVeyor)--> | ||
| <GitExtensionsReferenceVersion>latest</GitExtensionsReferenceVersion> | ||
| <!-- 'GitHub' or 'AppYevor' --> | ||
| <GitExtensionsReferenceSource>GitHub</GitExtensionsReferenceSource> | ||
| <!-- for local builds (no download) --> | ||
| <GitExtensionsPath>$(GitExtensionsDownloadPath)</GitExtensionsPath> | ||
| </PropertyGroup> | ||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add a section to readme under Good Practices stating that
GitExtensionsReferenceVersionused for local development should be synchronized withGitExtensions.Extensibilitypackage version, so local dev loop and published package targets the same version of Git Extensions.It's out of scope of this PR, so if you don't want to write it, I can do it in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so good on words, but I'll give it a try.I'm uncertain if I get what you mean, here.
GitExtensions.Extensibility"only" ensures a local copy of Git Extensions exists for local development. It "only" provides thepreBuildand thepostBuildtargets, does it not?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also adds a dependency in the built nuget package and we use this dependency to validate that the package is intended for the current main app version (we still have gaps in this area, but in general 0.3 means targeting Git Extensions v4).
As we don't have a stable API yet, you typically need to "hack" into what Git Extensions give you in the current plugin API, and so it is important to build against "similar" version that you the plugin to run in (most of my plugins needs at least recompilation between main app version upgrades).
Using "latest" can be dangerous, because it may download even preview version.