Strip dashes from accountPin in porting embed for Verizon portings #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plsr
changed the title
dharmadeveloper108
approved these changes
Aug 12, 2024
| .fn() | ||
| .mockImplementation(async () => porting) | ||
|
|
||
| ;(useUpdatePorting as jest.Mock).mockReturnValue(useUpdatePortingMock) |
There was a problem hiding this comment.
stray ;? 👀 something weird with the formatting perhaps?
There was a problem hiding this comment.
That's actually formatted this way by prettier/eslint. I think if we were to drop the semicolon it would be complied as currying
| "@tashi-iu/react-native-paper-dates": "^0.18.5", | ||
| "jest": "^29.2.1", | ||
| "jest-expo": "~50.0.2", |
There was a problem hiding this comment.
nit: I would have preferred to make a separate chore PR for this, this way e.g. if for some reason we have to revert the upgrade we don't also lose the PIN changes and vice versa,
but I'm also ok including the upgrade here 💖
There was a problem hiding this comment.
I agree. In this case not updating will break the Expo preview (they dropped support our SDK version completely), so I figured there might be little need to go back a version.
| .fn() | ||
| .mockImplementation(async () => porting) | ||
|
|
||
| ;(useUpdatePorting as jest.Mock).mockReturnValue(useUpdatePortingMock) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently learned that Verizon will display their users account PINs with dashes (e.g.
123-456) for better readability, but actually requires the PIN to be sent without dashes for port outs.Naturally, this cause users to copy the PIN in the format provided by Verizon, causing failed portings.
We have adapted Connect to automatically strip dashes from the
accountPinfield in the porting form for Verizon portings and decided to backport this functionality to our other products as well.Changes
<CarrierInfoForm />accepts a new prop (forbiddenPinChars) that defines an array of characters that the component strips from theaccountPinfield before submitting<PortingFormContainer />checks wether the current porting'sdonorProvideris Verizon and configures<CarrierInfoForm />to remove dashes from theaccountPinif that is the case.Unrelated Changes
51as Expo GO dropped support for SKD 49 & 50